<html>
<head><meta charset="utf-8"><title>I-prioritize #76399 Breaking behavior change for TokenStrea… · t-compiler/wg-prioritization/alerts · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/index.html">t-compiler/wg-prioritization/alerts</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html">I-prioritize #76399 Breaking behavior change for TokenStrea…</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="209207718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209207718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209207718">(Sep 06 2020 at 03:58)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="3111">@WG-prioritization/alerts</span> issue <a href="https://github.com/rust-lang/rust/issues/76399">#76399</a> has been requested for prioritization.</p>
<h1><a href="https://forge.rust-lang.org/compiler/prioritization/procedure.html#assign-priority-to-unprioritized-issues-with-i-prioritize-label">Procedure</a></h1>
<ul>
<li>Priority?</li>
<li>Regression?</li>
<li>Notify people/groups?</li>
<li>Needs <code>I-nominated</code>?</li>
</ul>



<a name="209232897"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209232897" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209232897">(Sep 06 2020 at 16:58)</a>:</h4>
<p>This looks like to be a fresh regression that immediately impacted some actual code. I'd say <code>P-high</code> (or above?) to bring it to attention to the next meeting. Makes sense?</p>



<a name="209235279"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209235279" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209235279">(Sep 06 2020 at 18:07)</a>:</h4>
<blockquote>
<p>I don't know which behavior above is correct but I would like it to be intentionally decided so that we know what behavior to implement in proc-macro2.</p>
</blockquote>
<p>I think this indeed deserves <code>I-nominated</code>. </p>
<blockquote>
<p>This breaks some real-world code such as the following, though only with old versions of some libraries as far as I have found. </p>
</blockquote>
<p>Even if it breaks only old versions of libraries I think we can afford a <code>P-high</code> or <code>P-critical</code> given that this behaviour was probably not intended in <a href="https://github.com/rust-lang/rust/issues/76285">#76285</a></p>



<a name="209332958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209332958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209332958">(Sep 07 2020 at 23:06)</a>:</h4>
<p>marking this as p-critical</p>



<a name="209332970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209332970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209332970">(Sep 07 2020 at 23:06)</a>:</h4>
<p>Issue <a href="https://github.com/rust-lang/rust/issues/76399">#76399</a>'s prioritization request has been removed.</p>



<a name="209346158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209346158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209346158">(Sep 08 2020 at 05:04)</a>:</h4>
<p>Does <code>I-nominated</code> make sense? <span class="user-mention" data-user-id="250987">@apiraino</span> <span class="user-mention" data-user-id="120823">@DPC</span></p>



<a name="209378655"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209378655" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209378655">(Sep 08 2020 at 12:27)</a>:</h4>
<p>I agree. The issue reporter asks for an opinion that requires a bit more context</p>



<a name="209380309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209380309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209380309">(Sep 08 2020 at 12:43)</a>:</h4>
<p>Critical issues do get discussed at the compiler meeting</p>



<a name="209380656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209380656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209380656">(Sep 08 2020 at 12:47)</a>:</h4>
<p>ah ok so in this case it would be redundant? <code>I-nominated</code> makes more sense on lower priority issues that we want anyway to be discussed, correct?</p>



<a name="209556170"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209556170" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209556170">(Sep 09 2020 at 19:23)</a>:</h4>
<p><code>P-critical</code> and <code>I-nominated</code> at the same time are somewhat redundant yeah</p>



<a name="209556225"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2376399%20Breaking%20behavior%20change%20for%20TokenStrea%E2%80%A6/near/209556225" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2376399.20Breaking.20behavior.20change.20for.20TokenStrea.E2.80.A6.html#209556225">(Sep 09 2020 at 19:23)</a>:</h4>
<p>still valid I think :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>